Changed aria label in main nav to resolve redundancy #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main navigation had an aria label that said main navigation. However, because it is a nav element, this results in hearing the word "navigation" twice with a screen reader. Changed "main navigation" to "main" to resolve this. Signed-off-by: Patrick Smyth <[email protected]>
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Patrick Smyth <[email protected]>
Signed-off-by: Patrick Smyth <[email protected]>
Signed-off-by: Patrick Smyth <[email protected]>
Signed-off-by: Patrick Smyth <[email protected]>
ltagliaferri
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main navigation had an aria label that said main navigation. However, because it is a nav element, this results in hearing the word "navigation" twice with a screen reader. Changed "main navigation" to "main" to resolve this.
Notes
Resolves #253